Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/15868#discussion_r87785862
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala
---
@@ -667,9 +667,15 @@ object JdbcUtils extends Logging {
val getConnection: () => Connection = createConnectionFactory(options)
val batchSize = options.batchSize
val isolationLevel = options.isolationLevel
- df.foreachPartition(iterator => savePartition(
- getConnection, table, iterator, rddSchema, nullTypes, batchSize,
dialect, isolationLevel)
- )
+ if (options.numPartitions != null && options.numPartitions.toInt !=
df.rdd.getNumPartitions) {
+
df.repartition(options.numPartitions.toInt).foreachPartition(iterator =>
savePartition(
--- End diff --
This repeats the `foreachPartition` part twice, when that could be outside
the if-else.
I don't know enough to say whether we should add this property. It seems a
little funny to set this globally to apply to all dataframes written to a
database. I understand the use case is pure SQL, where perhaps that's the only
option.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
