Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/15868#discussion_r87875679
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala
---
@@ -667,7 +667,14 @@ object JdbcUtils extends Logging {
val getConnection: () => Connection = createConnectionFactory(options)
val batchSize = options.batchSize
val isolationLevel = options.isolationLevel
- df.foreachPartition(iterator => savePartition(
+ val numPartitions = options.numPartitions
+ val repartitionedDF = if (numPartitions != null &&
+ numPartitions.toInt != df.rdd.getNumPartitions) {
--- End diff --
Tiny style point -- breaking the if statement that way looks a little funny
to my eyes. I might do ...
```
val repartitionedDF =
if (...) {
...
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
