Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15857#discussion_r87932789
  
    --- Diff: sql/core/src/test/resources/sql-tests/results/group-by.sql.out ---
    @@ -131,3 +131,11 @@ FROM testData
     struct<skewness(CAST(a AS DOUBLE)):double,kurtosis(CAST(a AS 
DOUBLE)):double,min(a):int,max(a):int,avg(a):double,var_samp(CAST(a AS 
DOUBLE)):double,stddev_samp(CAST(a AS 
DOUBLE)):double,sum(a):bigint,count(a):bigint>
     -- !query 13 output
     -0.2723801058145729        -1.5069204152249134     1       3       
2.142857142857143       0.8095238095238094      0.8997354108424372      15      
7
    +
    +
    +-- !query 14
    +SELECT COUNT(DISTINCT b), COUNT(DISTINCT b, c) FROM (SELECT 1 AS a, 2 AS 
b, 3 AS c) GROUP BY a
    --- End diff --
    
    is it also a regression test? I think you are just fixing `Expand` in this 
PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to