Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/15857#discussion_r87934920
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/FoldablePropagationSuite.scala
---
@@ -118,14 +118,30 @@ class FoldablePropagationSuite extends PlanTest {
Seq(
testRelation.select(Literal(1).as('x), 'a).select('x + 'a),
testRelation.select(Literal(2).as('x), 'a).select('x + 'a)))
- .select('x)
val optimized = Optimize.execute(query.analyze)
val correctAnswer = Union(
Seq(
testRelation.select(Literal(1).as('x),
'a).select((Literal(1).as('x) + 'a).as("(x + a)")),
testRelation.select(Literal(2).as('x),
'a).select((Literal(2).as('x) + 'a).as("(x + a)"))))
- .select('x).analyze
--- End diff --
We are not checking whether it is resolvable or not. See the PR
https://github.com/apache/spark/pull/15417
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
