Github user squito commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14079#discussion_r88121951
  
    --- Diff: 
core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala ---
    @@ -84,7 +85,7 @@ private[spark] class TaskSetManager(
       var totalResultSize = 0L
       var calculatedTasks = 0
     
    -  private val taskSetBlacklistHelperOpt: Option[TaskSetBlacklist] = {
    +  private[scheduler] val taskSetBlacklistHelperOpt: 
Option[TaskSetBlacklist] = {
    --- End diff --
    
    yeah good question.  I wondered this myself ... I thought about instead 
making an `Option[(TaskSetBlacklist, BlacklistTracker)]` but it just made all 
the other calls ugly.  I'll make it check whether blacklistTracker is set 
instead.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to