Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/14079#discussion_r88134308
--- Diff:
yarn/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala ---
@@ -691,11 +691,11 @@ private[spark] class ApplicationMaster(
}
override def receiveAndReply(context: RpcCallContext):
PartialFunction[Any, Unit] = {
- case RequestExecutors(requestedTotal, localityAwareTasks,
hostToLocalTaskCount) =>
+ case r: RequestExecutors =>
--- End diff --
suggestion from an earlier review -- I personally don't have a strong
preference, but I agree with the idea that there really isn't anything gained
by pulling apart the fields, just to repeat them all again. Easier to avoid
that here and just do `r.foo` in the next few lines. I don't think there is
any hard stance on style for this. (Lots of examples of this version in sql,
though sometimes it seems to have its own style ...)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
