Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/15644#discussion_r88528216
--- Diff:
core/src/test/scala/org/apache/spark/scheduler/TaskSchedulerImplSuite.scala ---
@@ -408,4 +625,30 @@ class TaskSchedulerImplSuite extends SparkFunSuite
with LocalSparkContext with B
assert(thirdTaskDescs.size === 0)
assert(taskScheduler.getExecutorsAliveOnHost("host1") ===
Some(Set("executor1", "executor3")))
}
+
+ test("don't update blacklist for shuffle-fetch failures, preemption,
denied commits, " +
--- End diff --
Should this test be in TaskSetManagerSuite.scala? It seems like it's really
testing the TSM (which is where updateBlacklistForFailedTask gets called) and
not the TaskScheduler.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
