Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/15644#discussion_r88613426
--- Diff:
core/src/test/scala/org/apache/spark/scheduler/TaskSetManagerSuite.scala ---
@@ -992,6 +994,46 @@ class TaskSetManagerSuite extends SparkFunSuite with
LocalSparkContext with Logg
assert(manager3.name === "TaskSet_1.1")
}
+ test("don't update blacklist for shuffle-fetch failures, preemption,
denied commits, " +
+ "or killed tasks") {
+ // Setup a taskset, and fail some tasks for a fetch failure,
preemption, denied commit,
+ // and killed task.
+ val conf = new SparkConf().
+ set(config.BLACKLIST_ENABLED, true)
+ sc = new SparkContext("local", "test", conf)
+ sched = new FakeTaskScheduler(sc, ("exec1", "host1"), ("exec2",
"host2"))
+ val taskSet = FakeTask.createTaskSet(4)
+ val tsm = new TaskSetManager(sched, taskSet, 4)
+ // we need a spy so we can attach our mock blacklist
+ val tsmSpy = spy(tsm)
+ val blacklist = mock(classOf[TaskSetBlacklist])
+ when(tsmSpy.taskSetBlacklistHelperOpt).thenReturn(Some(blacklist))
+
+ // make some offers to our taskset, to get tasks we will fail
+ val taskDescs = Seq(
+ "exec1" -> "host1",
+ "exec2" -> "host1"
+ ).flatMap { case (exec, host) =>
+ // offer each executor twice (simulating 2 cores per executor)
+ (0 until 2).flatMap{ _ => tsmSpy.resourceOffer(exec, host,
TaskLocality.ANY)}
+ }
--- End diff --
add check that this has length 4? (so there are no surprises later)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
