Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/15949#discussion_r88942966
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamExecution.scala
---
@@ -422,6 +432,7 @@ class StreamExecution(
val replacementMap = AttributeMap(replacements)
val triggerLogicalPlan = withNewSources transformAllExpressions {
case a: Attribute if replacementMap.contains(a) => replacementMap(a)
+ case t: CurrentTimestamp =>
CurrentBatchTimestamp(currentBatchTimestamp)
--- End diff --
Nevermind, I just read the JIRA, and I think I understand what is going on.
To me the `time` column in `df.groupBy('time)` is different from the `time`
column which is (apparently) in the source. I personally think it is better to
have the statefull aggregate produce a new time column, then to restrict push
down.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
