Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/15949#discussion_r88965945 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamExecution.scala --- @@ -344,8 +351,11 @@ class StreamExecution( } } if (hasNewData) { + // Current batch timestamp in seconds + currentBatchTimestamp = triggerClock.getTimeMillis() / 1000L reportTimeTaken(OFFSET_WAL_WRITE_LATENCY) { - assert(offsetLog.add(currentBatchId, availableOffsets.toOffsetSeq(sources)), + assert(offsetLog.add(currentBatchId, + availableOffsets.toOffsetSeq(sources, Some(currentBatchTimestamp.toString))), --- End diff -- It's better to have a new class like `StreamExecutionMetadata` to store all fields that need to be checkpointed, e.g., `currentBatchTimestamp`, `currentEventTimeWatermark`, and others that we may add in future.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org