Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/15949#discussion_r89235928
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamProgress.scala
---
@@ -26,8 +26,8 @@ class StreamProgress(
val baseMap: immutable.Map[Source, Offset] = new
immutable.HashMap[Source, Offset])
extends scala.collection.immutable.Map[Source, Offset] {
- def toOffsetSeq(source: Seq[Source]): OffsetSeq = {
- OffsetSeq(source.map(get))
+ def toOffsetSeq(source: Seq[Source], metadata: Option[String] = None):
OffsetSeq = {
--- End diff --
any need to make the metadata optional? Seems like we would want to always
pass on metadata when creating toOffsetSeq, and there is only couple of usages.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
