Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/15949#discussion_r89237005 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamExecution.scala --- @@ -422,6 +450,12 @@ class StreamExecution( val replacementMap = AttributeMap(replacements) val triggerLogicalPlan = withNewSources transformAllExpressions { case a: Attribute if replacementMap.contains(a) => replacementMap(a) + case ct: CurrentTimestamp => + CurrentBatchTimestamp(streamExecutionMetadata.currentBatchTimestampMillis, + ct.dataType) + case cd: CurrentDate => + CurrentBatchTimestamp(streamExecutionMetadata.currentBatchTimestampMillis, --- End diff -- Are you sure this is right? From what I see in tests about how CurrentDate is expected to be converted to literal, the millis should be exactly rounded to the day boundary. https://github.com/apache/spark/blob/master/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala#L47
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org