Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/16013#discussion_r89686396
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/types/DecimalType.scala ---
@@ -92,7 +92,8 @@ case class DecimalType(precision: Int, scale: Int)
extends FractionalType {
}
/**
- * The default size of a value of the DecimalType is 8 bytes (precision
<= 18) or 16 bytes.
+ * The default size of a value of the DecimalType is 8 bytes (precision
less than or equal to 18)
--- End diff --
This was unclear. I'd improve it to "The default size ... is 8 bytes when
precision is at most 18, and 16 bytes otherwise"
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
