Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/16013#discussion_r89686327
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/clustering/LDAOptimizer.scala ---
@@ -350,9 +350,12 @@ final class OnlineLDAOptimizer extends LDAOptimizer {
* Mini-batch fraction in (0, 1], which sets the fraction of document
sampled and used in
* each iteration.
*
- * @note This should be adjusted in synch with [[LDA.setMaxIterations()]]
+ * @note This should be adjusted in synch with `LDA.setMaxIterations()`
* so the entire corpus is used. Specifically, set both so that
+ *
+ * {{{
* maxIterations * miniBatchFraction >= 1.
+ * }}}
--- End diff --
Could also say "is at least 1". Letting it break into a separate code block
is awkward.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
