Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/16017#discussion_r89694871
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/DecisionTreeClassifier.scala
---
@@ -52,33 +52,49 @@ class DecisionTreeClassifier @Since("1.4.0") (
// Override parameter setters from parent trait for Java API
compatibility.
+ /** @group setParam */
@Since("1.4.0")
- override def setMaxDepth(value: Int): this.type =
super.setMaxDepth(value)
+ override def setMaxDepth(value: Int): this.type = set(maxDepth, value)
--- End diff --
Do you need to change this? I'd prefer the former, in case some special
logic is ever added to super.setMaxDepth.
Same elsewhere
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
