[GitHub] spark pull request #16017: [SPARK-18592][ML] Move DT/RF/GBT Param setter met...

[yanboliang]

Github user yanboliang commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16017#discussion_r89949760
  
    --- Diff: mllib/src/main/scala/org/apache/spark/ml/tree/treeParams.scala ---
    @@ -107,25 +107,41 @@ private[ml] trait DecisionTreeParams extends 
PredictorParams
       setDefault(maxDepth -> 5, maxBins -> 32, minInstancesPerNode -> 1, 
minInfoGain -> 0.0,
         maxMemoryInMB -> 256, cacheNodeIds -> false, checkpointInterval -> 10)
     
    -  /** @group setParam */
    +  /**
    +   * @deprecated This method is deprecated and will be removed in 2.2.0.
    +   * @group setParam
    +   */
    +  @deprecated("This method is deprecated and will be removed in 2.2.0.", 
"2.1.0")
    --- End diff --
    
    This will not appear in estimator classes, only in models. This can be 
confirmed by the following ways:
    The IDE will prompt deprecated methods only for models: 
    
![image](https://cloud.githubusercontent.com/assets/1962026/20699424/247abfc4-b5bc-11e6-8eb2-a9fe53661cba.png)
    We can also confirm it in Scala API docs:
    ```DecisionTreeClassifier```
    
![image](https://cloud.githubusercontent.com/assets/1962026/20699474/63b03688-b5bc-11e6-9e8d-b6d83f6bb00a.png)
    ```DecisionTreeClassificationModel```
    
![image](https://cloud.githubusercontent.com/assets/1962026/20699522/a0bf3556-b5bc-11e6-9289-d2c893f9428e.png)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org