Github user hhbyyh commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16020#discussion_r89780207
  
    --- Diff: 
mllib/src/main/scala/org/apache/spark/ml/clustering/BisectingKMeans.scala ---
    @@ -255,10 +256,19 @@ class BisectingKMeans @Since("2.0.0") (
     
       @Since("2.0.0")
       override def fit(dataset: Dataset[_]): BisectingKMeansModel = {
    +    val handlePersistence = dataset.rdd.getStorageLevel == 
StorageLevel.NONE
    --- End diff --
    
    Thanks for checking on this. I feel like we should have a unit test for 
this, but probably not here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to