Github user li-zhihui commented on the pull request:

    https://github.com/apache/spark/pull/1616#issuecomment-54408600
  
    @JoshRosen @andrewor14 
    
    I test the patch in yarn mode, and the <code>localDir</code> is a 
per-application temporary directory in this mode. Now I know it is a problem in 
standalone(and mesos) mode.
    <code>targetDir</code>(from <code>SparkFiles.getRootDirectory</code>) is 
per-executor temporary directory(in my case ,it is 
<code>/home/frank/hdfs/yarn/nm-local-dir/usercache/frank/appcache/application_1409795343243_0002/container_1409795343243_0002_01_000126/./</code>),
 I think we can use <code>targetDir + "../"</code> as per-application directory 
to save the cache file.
    
    BTW: The <code>timestamp</code>  follow this code's logic: 
https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/spark/executor/Executor.scala#L323
 Although I don't understand why the timestamp could be changed in an 
application's life time.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to