Github user li-zhihui commented on a diff in the pull request:
https://github.com/apache/spark/pull/1616#discussion_r17097313
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -317,13 +317,58 @@ private[spark] object Utils extends Logging {
}
/**
+ * Copy cached file to targetDir, if not exists, download it from url
firstly.
+ * If useCache == false, download file to targetDir directly.
--- End diff --
I want to keep the util method flexible primarily, because we make the old
<code>fetchFile</code> private. But I am not sure if the tag is necessary too.
@JoshRosen How do you think about it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
