Github user davies commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16193#discussion_r91394979
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/python/ExtractPythonUDFs.scala
 ---
    @@ -166,3 +174,40 @@ object ExtractPythonUDFs extends Rule[SparkPlan] {
         }
       }
     }
    +
    +// This rule is to push deterministic predicates through 
BatchEvalPythonExec
    +object PushPredicateThroughBatchEvalPython extends Rule[SparkPlan] with 
PredicateHelper {
    --- End diff --
    
    Having a predicate-pushdown rule for SparkPlan sounds bad, can we try to do 
this in extract()? for example
    ```
    val splittedFilter = trySplitFilter(plan)
    val newChildren = splittedFilter.children.map { child =>
    }
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to