Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/16252#discussion_r91923474
--- Diff:
core/src/main/scala/org/apache/spark/storage/memory/MemoryStore.scala ---
@@ -694,7 +694,7 @@ private[storage] class PartiallyUnrolledIterator[T](
}
override def next(): T = {
- if (unrolled == null) {
+ if (unrolled == null || unrolled.isEmpty) {
--- End diff --
For consistency with `hasNext`, should this be `!unrolled.hasNext`?
Although I don't know this code, this change seems correct. I suppose you could
also null out `unrolled` if you find it doesn't have more elements in `hasNext`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
