Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/16252#discussion_r91958066
--- Diff:
core/src/main/scala/org/apache/spark/storage/memory/MemoryStore.scala ---
@@ -694,7 +694,7 @@ private[storage] class PartiallyUnrolledIterator[T](
}
override def next(): T = {
- if (unrolled == null) {
+ if (unrolled == null || unrolled.isEmpty) {
--- End diff --
Ah yeah, it's in releaseUnrollMemory(). Does this not throw an exception
right now if next() is called before hasNext()? We kinda should also fix
TorrentBroadcast to either handle the exception or check hasNext()
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
