Github user shivaram commented on a diff in the pull request:
https://github.com/apache/spark/pull/16250#discussion_r92062052
--- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala
---
@@ -333,16 +333,16 @@ class DAGScheduler(
// (so we don't unnecessarily re-compute that data).
val serLocs =
mapOutputTracker.getSerializedMapOutputStatuses(shuffleDep.shuffleId)
val locs = MapOutputTracker.deserializeMapStatuses(serLocs)
- (0 until locs.length).foreach { i =>
- if (locs(i) ne null) {
- // locs(i) will be null if missing
- stage.addOutputLoc(i, locs(i))
+ locs.zipWithIndex
--- End diff --
Its hard to profile these things closely enough to figure out how much
overhead it adds (depends on locs.length of course etc.). My vote would be to
be conservative and keep the existing version
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
