Github user srowen commented on the issue:
https://github.com/apache/spark/pull/16250
The question is not whether there are downsides; there almost always some.
It's whether the upsides are bigger. We typically can't evaluate either of them
perfectly, but can take good guesses. The problem here isn't that downsides are
so clear or large, but that there is almost no upside. We change core all the
time, that's not the issue.
This is part of a meta-issue of overhead of processing the change. It's not
just whether a change is a tiny net win but whether, in the time needed to
process it, we could have done something else that's a bigger win.
(This extended aside is worthwhile because I think the overhead issue is
rarely appreciated; it is a non-issue on medium-sized projects but bites at
scale. Most projects would happily accept any change at all; this project is
way on the other end of that spectrum. It can be surprising.)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
