Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/16263#discussion_r92332668
--- Diff: python/pyspark/sql/dataframe.py ---
@@ -400,10 +402,19 @@ def toLocalIterator(self):
>>> list(df.toLocalIterator())
[Row(age=2, name=u'Alice'), Row(age=5, name=u'Bob')]
+ >>> it = df.toLocalIterator()
+ >>> import time
+ >>> time.sleep(5)
+ >>> next(it)
--- End diff --
It might make sense to test consuming the second element given that the fix
eagerly serves the first element, (and this additional test probably belongs in
tests.py rather than a doctest though).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
