Github user mridulm commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16380#discussion_r93566371
  
    --- Diff: 
core/src/main/scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala 
---
    @@ -315,6 +315,10 @@ final class ShuffleBlockFetcherIterator(
        * Throws a FetchFailedException if the next block could not be fetched.
        */
       override def next(): (BlockId, InputStream) = {
    +    if (!hasNext) {
    +      throw new NoSuchElementException
    +    }
    +
    --- End diff --
    
    A lot of our iterators dont seem to enforce this invariant


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to