Github user mridulm commented on a diff in the pull request:
https://github.com/apache/spark/pull/16380#discussion_r93577731
--- Diff:
core/src/main/scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala
---
@@ -315,6 +315,10 @@ final class ShuffleBlockFetcherIterator(
* Throws a FetchFailedException if the next block could not be fetched.
*/
override def next(): (BlockId, InputStream) = {
+ if (!hasNext) {
+ throw new NoSuchElementException
+ }
+
--- End diff --
Dont get me wrong, I am proposing we do similar everywhere : not remove it
from here !
This is the expectation from Iterator interface; which we do not honour
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
