Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/16346#discussion_r93682032
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/SparkListener.scala ---
@@ -106,6 +106,28 @@ case class SparkListenerExecutorRemoved(time: Long,
executorId: String, reason:
extends SparkListenerEvent
@DeveloperApi
+case class SparkListenerExecutorBlacklisted(
+ time: Long,
+ executorId: String,
+ taskFailures: Int)
+ extends SparkListenerEvent
+
+@DeveloperApi
+case class SparkListenerExecutorUnblacklisted(time: Long, executorId:
String)
+ extends SparkListenerEvent
+
+@DeveloperApi
+case class SparkListenerNodeBlacklisted(
+ time: Long,
+ nodeId: String,
--- End diff --
Hmm... I don't remember `nodeId` being a thing in Spark. Do you mean a
hostname here, or ip address, or something else? Should probably use a better
name, or at least document what it is.
(I see BlacklistTracker uses that, but as a user, I don't know what
"nodeId" is.)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
