Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/16346#discussion_r93683196
--- Diff:
core/src/test/scala/org/apache/spark/scheduler/BlacklistTrackerSuite.scala ---
@@ -40,7 +41,7 @@ class BlacklistTrackerSuite extends SparkFunSuite with
BeforeAndAfterEach with M
scheduler = mockTaskSchedWithConf(conf)
clock.setTime(0)
- blacklist = new BlacklistTracker(conf, clock)
+ blacklist = new BlacklistTracker(null, conf, clock)
--- End diff --
If this tracker is ever used, won't you get NPEs because the listener bus
is null?
This basically means you're forcing every test to call
`configureBlacklistAndScheduler()` manually. So either remove this
initialization, or do this properly, and just call
`configureBlacklistAndScheduler()` for tests that need to override the default
config.
Since I don't see any test actually passing any custom config parameters,
might as well do the initialization properly here and get rid of
`configureBlacklistAndScheduler()` altogether.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
