Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/15996#discussion_r93723071
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/PartitionProviderCompatibilitySuite.scala
---
@@ -195,12 +195,25 @@ class PartitionProviderCompatibilitySuite
withTempDir { dir =>
setupPartitionedDatasourceTable("test", dir)
if (enabled) {
- spark.sql("msck repair table test")
+ assert(spark.table("test").count() == 0)
+ } else {
+ assert(spark.table("test").count() == 5)
}
- assert(spark.sql("select * from test").count() == 5)
- spark.range(10).selectExpr("id as fieldOne", "id as partCol")
+
+ spark.range(3, 13).selectExpr("id as fieldOne", "id as
partCol")
.write.partitionBy("partCol").mode("append").saveAsTable("test")
- assert(spark.sql("select * from test").count() == 15)
+
+ if (enabled) {
+ // Only the newly written partitions are visible, which
means the partitions
--- End diff --
to be consistent with the behavior of `InsertItoTable`. I'll add that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
