Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/16409#discussion_r93901001
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCWriteSuite.scala ---
@@ -44,9 +44,6 @@ class JDBCWriteSuite extends SharedSQLContext with
BeforeAndAfter {
val testH2Dialect = new JdbcDialect {
override def canHandle(url: String) : Boolean =
url.startsWith("jdbc:h2")
- override def getCatalystType(
--- End diff --
Thank you for review, @gatorsmile .
`JdbcDialect` should handle a few DBMS specific types and should return
`None` for general types. The schema is handled in general in the following
fallback logic.
https://github.com/apache/spark/blob/master/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala#L245-L246
The current implementation is wrong because it returns always `StringType`
for all kind types of columns.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
