Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/16409#discussion_r93902654
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCWriteSuite.scala ---
@@ -44,9 +44,6 @@ class JDBCWriteSuite extends SharedSQLContext with
BeforeAndAfter {
val testH2Dialect = new JdbcDialect {
override def canHandle(url: String) : Boolean =
url.startsWith("jdbc:h2")
- override def getCatalystType(
--- End diff --
First of all, it's my bad that I didn't notice that there were two
`testH2Dialect`.
Now, I understand that this is intentional for the specific test case
`Remap types via JdbcDialects`, but it seems to be only valid for
`JDBCSuite.scala`.
I mean we can use a normal JdbcDialect in `JDBCWriteSuite` because it's a
different suite. Actually, while making #15664, I got stuck by this bug.
Is it possible to fix this correctly in `JDBCWriterSuite`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
