Github user dongjoon-hyun commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15664#discussion_r94216756
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcRelationProvider.scala
 ---
    @@ -67,16 +68,18 @@ class JdbcRelationProvider extends 
CreatableRelationProvider
                 if (isTruncate && isCascadingTruncateTable(url) == 
Some(false)) {
                   // In this case, we should truncate table and then load.
                   truncateTable(conn, table)
    -              saveTable(df, url, table, jdbcOptions)
    +              val tableSchema = JdbcUtils.getSchemaOption(conn, url, table)
    --- End diff --
    
    I moved this into `case` statements.
    Since `JdbcUtils.tableExists` is used, `getSchemaOption` can be skipped for 
the other `SaveMode`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to