Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/15664#discussion_r94216803
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala
---
@@ -108,14 +108,36 @@ object JdbcUtils extends Logging {
}
/**
- * Returns a PreparedStatement that inserts a row into table via conn.
+ * Returns an Insert SQL statement for inserting a row into the target
table via JDBC conn.
*/
- def insertStatement(conn: Connection, table: String, rddSchema:
StructType, dialect: JdbcDialect)
- : PreparedStatement = {
- val columns = rddSchema.fields.map(x =>
dialect.quoteIdentifier(x.name)).mkString(",")
+ def getInsertStatement(
+ table: String,
+ rddSchema: StructType,
+ tableSchema: Option[StructType],
+ isCaseSensitive: Boolean,
+ dialect: JdbcDialect): String = {
+ val columns = if (tableSchema.isEmpty) {
+ rddSchema.fields.map(x =>
dialect.quoteIdentifier(x.name)).mkString(",")
--- End diff --
The legacy behavior is used when `tableSchema` is `None`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
