Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/16371#discussion_r94232541
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/RewriteDistinctAggregatesSuite.scala
---
@@ -63,7 +63,7 @@ class RewriteDistinctAggregatesSuite extends PlanTest {
val input = testRelation
.groupBy('a, 'd)(
countDistinct('e, 'c).as('agg1),
- CollectSet('b).toAggregateExpression().as('agg2))
+ DummpAgg('b).toAggregateExpression().as('agg2))
--- End diff --
i was thought about removing it. however, `RewriteDistinctAggregates` rule
has logic for this case. this test is the only one for testing this logic. so i
didn't remove it in the end.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
