Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/16371#discussion_r94234184 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/RewriteDistinctAggregatesSuite.scala --- @@ -63,7 +63,7 @@ class RewriteDistinctAggregatesSuite extends PlanTest { val input = testRelation .groupBy('a, 'd)( countDistinct('e, 'c).as('agg1), - CollectSet('b).toAggregateExpression().as('agg2)) + DummpAgg('b).toAggregateExpression().as('agg2)) --- End diff -- If we remove the logic from RewriteDistinctAggregates, we need to make sure that non-partial aggregates do not exist anymore. Lets do this in a follow-up.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org