Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/16441#discussion_r95286979 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/GBTClassifier.scala --- @@ -248,12 +268,38 @@ class GBTClassificationModel private[ml]( if (prediction > 0.0) 1.0 else 0.0 } + override protected def predictRaw(features: Vector): Vector = { + val treePredictions = _trees.map(_.rootNode.predictImpl(features).prediction) --- End diff -- we can avoid duplicating this code. Maybe, as in LogisticRegression, we can create a private function called `score` or `margin` and then use that in `predict` and `predictRaw`
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org