Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/16441#discussion_r95286255 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/GBTClassifier.scala --- @@ -159,14 +157,21 @@ class GBTClassifier @Since("1.4.0") ( val numFeatures = oldDataset.first().features.size val boostingStrategy = super.getOldBoostingStrategy(categoricalFeatures, OldAlgo.Classification) - val instr = Instrumentation.create(this, oldDataset) + val numClasses: Int = getNumClasses(dataset) --- End diff -- We should just use numClasses = 2 for now, since `getNumClasses` can make an extra pass over the data, and >2 classes are not supported anyway.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org