Github user jiangxb1987 commented on a diff in the pull request: https://github.com/apache/spark/pull/16497#discussion_r95295476 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Percentile.scala --- @@ -126,10 +152,15 @@ case class Percentile( buffer: OpenHashMap[Number, Long], input: InternalRow): OpenHashMap[Number, Long] = { val key = child.eval(input).asInstanceOf[Number] + val frqValue = frequency.eval(input) // Null values are ignored in counts map. - if (key != null) { - buffer.changeValue(key, 1L, _ + 1L) + if (key != null && frqValue != null) { --- End diff -- This is dangerous, we should use a default value (e.g. frqValue = 1) when frqValue is invalid.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org