Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16497#discussion_r95294336
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Percentile.scala
---
@@ -51,16 +51,31 @@ import org.apache.spark.util.collection.OpenHashMap
_FUNC_(col, array(percentage1 [, percentage2]...)) - Returns the
exact percentile value array
of numeric column `col` at the given percentage(s). Each value of
the percentage array must
be between 0.0 and 1.0.
- """)
+
+ _FUNC_(col, frequency, percentage) - Returns the exact percentile
value of numeric
+ column `col` with frequency column `frequency` at the given
percentage. The value of
+ percentage must be between 0.0 and 1.0.
+
+ _FUNC_(col, frequency, array(percentage1 [, percentage2]...)) -
Returns the exact percentile
+ value array of numeric column `col` with frequency column
`frequency` at the given
+ percentage(s).Each value of the percentage array must be between 0.0
and 1.0.
+
+ """)
case class Percentile(
child: Expression,
+ frequency : Expression,
percentageExpression: Expression,
+ withFrqExpr : Boolean,
--- End diff --
Let's make the type of `frequency` to be `Option[Expression]`, and remove
the `withFrqExpr` flag.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
