Github user andrewor14 commented on the pull request:

    https://github.com/apache/spark/pull/1106#issuecomment-54853445
  
    This still doesn't deal with the fact that we can over-subscribe a worker 
by scheduling more drivers on it than the worker's resources allow. Since this 
wasn't dealt with even before this patch, I think it's fine to save it for 
later. I left a few minor comments, but the changes look good for the most part.
    
    retest this please


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to