Github user WangTaoTheTonic commented on the pull request:
https://github.com/apache/spark/pull/1106#issuecomment-54928936
@markhamstra Thanks for pointing out the shuffle problem. I tested and the
result proved that you are right on this.
As for the keeping not alive workers question, I thought the filter will
create a copy of workers so decided to filter in iteration. It is a time-space
tradeoff.
Now since the worker HashSet should be transfered to Seq before shuffle, we
could put filter before shuffle as you said.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
