Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16308#discussion_r95344871
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
---
@@ -30,21 +30,48 @@ import org.apache.spark.sql.types._
import org.apache.spark.unsafe.types.{CalendarInterval, UTF8String}
/**
+ * Common base class for time zone aware expressions.
+ */
+trait TimeZoneAwareExpression extends Expression {
+
+ /** the timezone ID. */
+ def timeZoneId: String
+
+ /**
+ * Returns true if the timezone ID is resolved.
+ * If not resolved, the analyzer [[ResolveTimeZone]] will resolve with
session local timezone.
+ */
+ def timeZoneResolved: Boolean = timeZoneId != null
--- End diff --
Does it worth to add such a concept? What if we just set session local
timezone for every `TimeZoneAwareExpression`? It seems to me that it's ok to
call `withTimeZone` blindly, as the `ResolveTimeZone` rule will only run once.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
