Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/16308#discussion_r95400494
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
---
@@ -30,21 +30,48 @@ import org.apache.spark.sql.types._
import org.apache.spark.unsafe.types.{CalendarInterval, UTF8String}
/**
+ * Common base class for time zone aware expressions.
+ */
+trait TimeZoneAwareExpression extends Expression {
+
+ /** the timezone ID. */
+ def timeZoneId: String
+
+ /**
+ * Returns true if the timezone ID is resolved.
+ * If not resolved, the analyzer [[ResolveTimeZone]] will resolve with
session local timezone.
+ */
+ def timeZoneResolved: Boolean = timeZoneId != null
--- End diff --
I think that there might be a case that we let users explicitly set the
timezone id, e.g. adding such functions to `functions.scala`. If so, we can't
simply replace the timezone id by session local timezone.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
