Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16561#discussion_r96167779
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/view.scala
---
@@ -28,22 +28,56 @@ import org.apache.spark.sql.catalyst.rules.Rule
*/
/**
- * Make sure that a view's child plan produces the view's output
attributes. We wrap the child
- * with a Project and add an alias for each output attribute. The
attributes are resolved by
- * name. This should be only done after the batch of Resolution, because
the view attributes are
- * not completely resolved during the batch of Resolution.
+ * Make sure that a view's child plan produces the view's output
attributes. We try to wrap the
+ * child by:
+ * 1. Generate the `queryOutput` by:
+ * 1.1. If the query column names are defined, map the column names to
attributes in the child
+ * output by name;
--- End diff --
should we mention that, this is mostly for `SELECT * ...`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
