Github user staple commented on the pull request:
https://github.com/apache/spark/pull/1706#issuecomment-55003039
The primary master change resulting in a merge conflict with this patch was
the addition of a call to the new ExtractPythonUdfs rule in HiveContext. For
now I decided to leave the explicit call to the ExtractPythonUdfs rule in
place, rather than incorporate it into the Analyzer along with the CreateTables
and PreInsertionCasts rules I moved there. I am not aware that
ExtractPythonUdfs can affect query plan resolution, and I havenât checked
what the consequences would be if the ExtractPythonUdfs rule were called
multiple times (on multiple PythonUDFs) which could happen if the rule were
added to an Analyzer batch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
