Github user staple commented on a diff in the pull request:

    https://github.com/apache/spark/pull/1706#discussion_r17340821
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
 ---
    @@ -40,7 +40,12 @@ class Analyzer(catalog: Catalog, registry: 
FunctionRegistry, caseSensitive: Bool
       // TODO: pass this in as a parameter.
       val fixedPoint = FixedPoint(100)
     
    -  val batches: Seq[Batch] = Seq(
    +  /**
    +   * Override to provide additional rules for the "Resolution" batch.
    +   */
    +  val extendedRules: List[Rule[LogicalPlan]] = Nil
    --- End diff --
    
    I'd made it a List in order to use the triple colon concat operator in 
Analyzer for consistency with the existing code that uses double colon, but 
sure I can change to Seq instead since that's preferred.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to