Github user lins05 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16593#discussion_r96774234
  
    --- Diff: 
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/CreateHiveTableAsSelectCommand.scala
 ---
    @@ -87,8 +101,8 @@ case class CreateHiveTableAsSelectCommand(
           }
         } else {
           try {
    -        sparkSession.sessionState.executePlan(InsertIntoTable(
    -          metastoreRelation, Map(), query, overwrite = true, ifNotExists = 
false)).toRdd
    +        
sparkSession.sessionState.executePlan(InsertIntoTable(metastoreRelation,
    --- End diff --
    
    IIUC the partition syntax doesn't contain type, e.g. ```create table t2 
using hive partitioned by (c1, c2) as select * from t1```. If one specify 
`partition by (c1 string, c2 int)` the parser would raise an error, because we 
have this specified in the parser syntax:
    
    ```g4
            createTableHeader ...
            (PARTITIONED BY partitionColumnNames=identifierList)?
            ... #createTable
    
    identifierList
        : '(' identifierSeq ')'
        ;
    
    identifierSeq
        : identifier (',' identifier)*
        ;
    
    ```



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to