Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16593#discussion_r96783111
  
    --- Diff: 
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/CreateHiveTableAsSelectCommand.scala
 ---
    @@ -87,8 +101,8 @@ case class CreateHiveTableAsSelectCommand(
           }
         } else {
           try {
    -        sparkSession.sessionState.executePlan(InsertIntoTable(
    -          metastoreRelation, Map(), query, overwrite = true, ifNotExists = 
false)).toRdd
    +        
sparkSession.sessionState.executePlan(InsertIntoTable(metastoreRelation,
    --- End diff --
    
    here we only reorder the columns of the query plan by name, and construct a 
`InsertIntoTable` plan, other rules will take care of `InsertIntoTable` and do 
cast. But yes, we should add a test


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to