Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/16659#discussion_r97201707 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala --- @@ -780,9 +780,6 @@ class CodegenContext { // The cost of doing subexpression elimination is: // 1. Extra function call, although this is probably *good* as the JIT can decide to --- End diff -- but we do have an extra function call to evaluate common subexpression elimination at the beginning.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org